Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multi verifier name #11

Closed
wants to merge 42 commits into from
Closed

Enable multi verifier name #11

wants to merge 42 commits into from

Conversation

junczhu
Copy link

@junczhu junczhu commented Dec 6, 2023

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

junczhu and others added 25 commits November 23, 2023 19:27
@junczhu
feat: enable showing verifier name
ae7da73
@junczhu
feat: enable showing verifier name 2
6e96827
@junczhu
feat: enable showing verifier name related ut
2387b5b
@junczhu
feat: enable showing verifier name related ut2
dcee0b2
@junczhu
feat: enable showing verifier name related ut3
e46748c
@junczhu
feat: enable showing verifier name related ut4
f7bc7ea
@junczhu
feat: enable showing verifier name related ut5
f52f0ab
@junczhu
feat: enable showing verifier name related ut6
8d81fae
@junczhu
feat: enable showing verifier name related ut7
fdbb175
@junczhu
feat: enable showing verifier name related ut8
a68ecbb
@junczhu
feat:set verifier type as optional property, added to notation vResult
da1b552
@junczhu
chore: create func verifierCreateConfig, added err catcher
e8aea98
@junczhu
fix: update verifier dynamic cli-test
004f8e4
@junczhu
fix: update verifier creation llog
9e15057
@junczhu
fix: update verifier creation log2
20a95c5
@junczhu
fix: update verifier creation log3
a549c06
@junczhu
Merge branch 'main' into enable-multi-verifier-name
218606f
@junczhu
fix: update verifier plugin log for e2e test
6efa929
@junczhu
fix: typo; CT for notation plugin
78bfe26
@junczhu
test: e2e test for verifier with type and multi verifier
4a8e33c
@junczhu
feat: resolve comments; fix: e2e test
e2f5b41
@junczhu
fix: go-lint
0dfeda7
@junczhu
fix: golangci-lint
62ae222
@junczhu
fix: rename variable
2e0bf7f
@junczhu
Merge branch 'main' into enable-multi-verifier-name
54304e4
@junczhu junczhu requested a review from binbin-li as a code owner December 6, 2023 07:40
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2023 •
edited
Loading

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (2a2cfd3) 54.92% compared to head (2ff1060) 55.09%.

Files Patch % Lines
plugins/verifier/cosign/cosign.go 10.00% 17 Missing and 1 partial ⚠️
plugins/verifier/sbom/sbom.go 41.66% 6 Missing and 1 partial ⚠️
...rifier/vulnerabilityreport/vulnerability_report.go 80.00% 5 Missing and 1 partial ⚠️
...ugins/verifier/schemavalidator/schema_validator.go 28.57% 4 Missing and 1 partial ⚠️
pkg/verifier/factory/factory.go 78.57% 1 Missing and 2 partials ⚠️
pkg/executor/core/testtypes.go 33.33% 2 Missing ⚠️
pkg/verifier/plugin/plugin.go 83.33% 2 Missing ⚠️
pkg/controllers/verifier_controller.go 88.88% 0 Missing and 1 partial ⚠️
pkg/verifier/notation/notation.go 94.44% 1 Missing ⚠️
plugins/verifier/licensechecker/licensechecker.go 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   54.92%   55.09%   +0.16%     
==========================================
  Files         104      104              
  Lines        6780     6865      +85     
==========================================
+ Hits         3724     3782      +58     
- Misses       2728     2751      +23     
- Partials      328      332       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junczhu junczhu mentioned this pull request Dec 7, 2023
Merged
12 tasks
@junczhu junczhu closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binbin-li binbin-li Awaiting requested review from binbin-li binbin-li is a code owner

Assignees
No one assigned
Labels
safe to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@junczhu